Skip to content

Upgrade dependencies, scope, and downgrade to match minimum PHP#13

Merged
snake14 merged 4 commits into
5.x-devfrom
PG-4540-scope-dependencies
Oct 2, 2025
Merged

Upgrade dependencies, scope, and downgrade to match minimum PHP#13
snake14 merged 4 commits into
5.x-devfrom
PG-4540-scope-dependencies

Conversation

@snake14

@snake14 snake14 commented Sep 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Upgrading, scoping, and transpiling dependencies (Rector downgraded them to be PHP 7.3 compatible). There were no manual changes in the vendor/ directory, and if you ignore that directory, only 7 files were altered.

Issue No

PG-4540

Steps to Replicate the Issue

  1. Check out the latest version of CustomReports
  2. Check out this PR branch
  3. Run the command to build annotations: ddev matomo:console openapidocs:generate-annotations --plugin=CustomReports --not-dry-run
  4. Note that there were no errors and the generated annotations are nearly identical to before.
  5. Run the command to build a spec file: ddev matomo:console openapidocs:generate-spec-file --plugin=CustomReports --not-dry-run
  6. Note that there were no errors and the generated spec file is nearly identical to before.

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [NA] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✖] Version bumped?

@snake14 snake14 added the Needs Review For pull requests that need a code review. label Oct 1, 2025
@snake14 snake14 requested review from a team and removed request for a team October 1, 2025 22:10
@snake14

snake14 commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

Apologies for accidentally tagging you for review @matomo-org/core-reviewers . Please disregard this PR.

@snake14 snake14 marked this pull request as ready for review October 1, 2025 22:15
james-hill-matomo
james-hill-matomo approved these changes Oct 2, 2025
View reviewed changes

@james-hill-matomo james-hill-matomo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing, I tried generating annotations for the Whitelabel plugin, and it didn't work for me. I wouldn't worry too much about this at this stage, but thought it was worth mentioning.

jms@WI-LIN-ENG-JH-1:~/dev/matomo_5x-dev/plugins/OpenApiDocs$ ddev matomo:console plugin:activate WhiteLabel
The plugin WhiteLabel is already activated.
jms@WI-LIN-ENG-JH-1:~/dev/matomo_5x-dev/plugins/OpenApiDocs$ ddev matomo:console openapidocs:generate-annotations --plugin=plugin-Whitelabel
Generating annotations for: plugin-Whitelabel
ERROR     [2025-10-02 00:38:06] 43971  Uncaught exception: /core/Plugin/Manager.php(304): The plugin plugin-Whitelabel is not enabled. You can activate the plugin on Settings > Plugins page in Matomo.
#0 /plugins/OpenApiDocs/Annotations/AnnotationGenerator.php(108): Piwik\Plugin\Manager->checkIsPluginActivated('plugin-Whitelab...')

Other than that, tested working OK in both PHP 7.2 and 8.2.

Thank you :)

Comment thread Annotations/GlobalApiComponents.php
Comment thread composer.json
Comment thread vendor/autoload_original.php
Comment thread README.md
@snake14

snake14 commented Oct 2, 2025

Copy link
Copy Markdown
Contributor Author

While testing, I tried generating annotations for the Whitelabel plugin, and it didn't work for me. I wouldn't worry too much about this at this stage, but thought it was worth mentioning.

jms@WI-LIN-ENG-JH-1:~/dev/matomo_5x-dev/plugins/OpenApiDocs$ ddev matomo:console plugin:activate WhiteLabel
The plugin WhiteLabel is already activated.
jms@WI-LIN-ENG-JH-1:~/dev/matomo_5x-dev/plugins/OpenApiDocs$ ddev matomo:console openapidocs:generate-annotations --plugin=plugin-Whitelabel
Generating annotations for: plugin-Whitelabel
ERROR     [2025-10-02 00:38:06] 43971  Uncaught exception: /core/Plugin/Manager.php(304): The plugin plugin-Whitelabel is not enabled. You can activate the plugin on Settings > Plugins page in Matomo.
#0 /plugins/OpenApiDocs/Annotations/AnnotationGenerator.php(108): Piwik\Plugin\Manager->checkIsPluginActivated('plugin-Whitelab...')

Other than that, tested working OK in both PHP 7.2 and 8.2.

Thank you :)

@james-hill-matomo I guess the messaging could be improved, but it's likely because the Whitelabel plugin doesn't define an API class.

@snake14 snake14 merged commit c082b2f into 5.x-dev Oct 2, 2025
7 checks passed
@snake14 snake14 deleted the PG-4540-scope-dependencies branch October 2, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@james-hill-matomo james-hill-matomo james-hill-matomo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Needs Review For pull requests that need a code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@snake14 @james-hill-matomo